refactor auth #17962
Merged
refactor auth #17962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
KN4CK3R
approved these changes
Dec 12, 2021
GiteaBot
added
the
lgtm/need 1
lunny
force-pushed
the
lunny/auth_refactor
branch
2 times, most recently
from
240d8a3 to
565f720
Compare
lafriks
reviewed
Dec 13, 2021
lunny
force-pushed
the
lunny/auth_refactor
branch
from
565f720 to
7ff8160
Compare
wxiaoguang
reviewed
Dec 16, 2021
wxiaoguang
reviewed
Dec 16, 2021
wxiaoguang
reviewed
Dec 16, 2021
wxiaoguang
reviewed
Dec 16, 2021
|
Some comments are broken by replacing
|
lunny
force-pushed
the
lunny/auth_refactor
branch
3 times, most recently
from
2e865dc to
6f27865
Compare
done. |
This comment has been minimized.
This comment has been minimized.
wxiaoguang
requested changes
Dec 27, 2021
lunny
force-pushed
the
lunny/auth_refactor
branch
from
834fef0 to
552d21a
Compare
|
@wxiaoguang I think all done. |
wxiaoguang
approved these changes
Jan 2, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 4, 2022
* giteaoffical/main: (22 commits) Add MP4 as default allowed attachment type (go-gitea#18170) [skip ci] Updated translations via Crowdin Include folders into size cost (go-gitea#18158) Don't delete branch if other PRs with this branch are open (go-gitea#18164) Remove unused route "/tasks/trigger" (go-gitea#18160) Fix EasyMDE validation (go-gitea#18161) Fix bug (go-gitea#18168) tests: add coverage for models migration helpers (go-gitea#18162) [skip ci] Updated translations via Crowdin Require codereview to have content (go-gitea#18156) chore(lint): use golangci-lint to call revive and misspell checker. (go-gitea#18145) Update owners for 2022 (go-gitea#18155) Refactor auth package (go-gitea#17962) Unify and simplify TrN for i18n (go-gitea#18141) Use correct user when determining max repo limits for error messages (go-gitea#18153) Add singuliere to MAINTAINERS (go-gitea#18148) [skip ci] Updated licenses and gitignores Add API to get issue/pull comments and events (timeline) (go-gitea#17403) Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138) Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138) ...
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 2, 2022
There was an unfortunate regression in go-gitea#17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix go-gitea#18561 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 2, 2022
Backport go-gitea#18562 There was an unfortunate regression in go-gitea#17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix go-gitea#18561 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
Feb 3, 2022
There was an unfortunate regression in #17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix #18561 Signed-off-by: Andrew Thornton <[email protected]>
lunny
pushed a commit
that referenced
this pull request
Feb 3, 2022
Backport #18562 There was an unfortunate regression in #17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix #18561 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
There was an unfortunate regression in go-gitea#17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix go-gitea#18561 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models/logintomodels/authsecuritysetting files into a subsecurityfoldersecurity_*.tmplintosecurity/*.tmpl